solution #2700
solution #2700
Conversation
src/transformState.js
Outdated
| break; | ||
|
|
||
| case 'removeProperties': | ||
| if (keysToRemove) { |
There was a problem hiding this comment.
Unnecessary condition. If 'keysToRemove' is not provided, the for...of loop will simply not run. Therefore, the if (keysToRemove) condition is redundant and can be removed.
src/transformState.js
Outdated
| case 'removeProperties': | ||
| if (keysToRemove) { | ||
| for (const key of keysToRemove) { | ||
| if (state.hasOwnProperty(key)) { |
There was a problem hiding this comment.
The hasOwnProperty check is not necessary when deleting a property. JavaScript will not throw an error if you try to delete a property that does not exist. Thus, this line can be safely removed.
src/transformState.js
Outdated
| @@ -6,6 +6,36 @@ | |||
| */ | |||
| function transformState(state, actions) { | |||
| // write code here | |||
| for (const action of actions) { | |||
| const { type, extraData, keysToRemove } = action; | |||
There was a problem hiding this comment.
Inconsistent destructuring of 'action'. The task description mentions that the second property of the action object can vary depending on the type, but here you're destructuring 'extraData' and 'keysToRemove' regardless of the type. You should move the destructuring inside the corresponding case blocks.
src/transformState.js
Outdated
| break; | ||
|
|
||
| case 'removeProperties': | ||
| if (keysToRemove) { |
No description provided.